File size: 4,798 Bytes
2bb821d |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 |
# 🐛 Bug Fixes Applied
## Issues Identified from Logs
Based on the container logs, three main issues were identified and fixed:
### 1. ✅ Circular Reference Error in Context Manager
**Error**: `Context update error: Circular reference detected`
**Root Cause**: The context manager was trying to store the entire context object (including itself) in the interactions, causing a circular reference when serializing to JSON.
**Fix Applied** (`context_manager.py`):
- Removed the full context from being stored in each interaction
- Created a clean `session_context` dictionary with only essential fields
- Avoids circular references by storing only necessary data
**Before**:
```python
new_interaction = {
"user_input": user_input,
"timestamp": datetime.now().isoformat(),
"context": context # ❌ Circular reference!
}
```
**After**:
```python
# Create a clean interaction without circular references
new_interaction = {
"user_input": user_input,
"timestamp": datetime.now().isoformat()
}
# Use a clean context copy for JSON serialization
session_context = {
"interactions": context.get("interactions", []),
"preferences": context.get("preferences", {}),
"active_tasks": context.get("active_tasks", [])
}
```
### 2. ✅ Unhashable Type 'slice' Error in Safety Agent
**Error**: `SAFETY_BIAS_001 error: unhashable type: 'slice'`
**Root Cause**: The safety agent was receiving dictionaries instead of strings, and the `_generate_warnings` method had a bug with list comprehension.
**Fix Applied** (`src/agents/safety_agent.py`):
1. Made `execute` method accept both string and dict inputs
2. Fixed the list comprehension that was causing the slice error
3. Added better error handling with full stack traces
**Changes**:
```python
# Before: Only accepted strings
async def execute(self, response: str, ...):
# After: Handles both types
async def execute(self, response, ...):
if isinstance(response, dict):
response_text = response.get('final_response', response.get('response', str(response)))
else:
response_text = str(response)
```
```python
# Before: Buggy list comprehension
if category in self.warning_templates and category not in [w.split(":")[1].strip() for w in warnings]:
# After: Clean check
if category and category in self.warning_templates:
category_warning = self.warning_templates[category]
if category_warning not in warnings:
warnings.append(category_warning)
```
### 3. ✅ Empty Response from Synthesis Agent
**Error**: `Orchestrator returned response: ` (empty)
**Root Cause**: When no agent outputs were provided, the synthesis agent returned empty strings, which propagated to a blank response.
**Fix Applied** (`src/agents/synthesis_agent.py`):
- Added fallback responses when content blocks are empty
- Ensured `_structure_conversational_response` always returns something useful
- Added checks in `_template_based_synthesis` to generate a response even with no content
**Changes**:
```python
# Added fallback in _template_based_synthesis
if not structured_response or len(structured_response.strip()) == 0:
structured_response = f"Thank you for your message: '{user_input}'. I'm working on understanding how to best help you with this."
```
```python
# Added fallback in _structure_conversational_response
if len(combined_content) == 0:
return "I'm here to help. Could you tell me more about what you're looking for?"
```
### 4. ✅ Improved Final Output Formatting
**Enhancement**: Made the orchestrator extract responses from multiple possible locations
**Changes** (`orchestrator_engine.py`):
```python
# Extracts from multiple possible locations
response_text = (
response.get("final_response") or
response.get("safety_checked_response") or
response.get("original_response") or
response.get("response") or
str(response.get("result", ""))
)
# Fallback if all empty
if not response_text:
response_text = "I apologize, but I'm having trouble generating a response right now. Please try again."
```
## Test Results After Fixes
All fixes have been applied and should resolve:
- ✅ No more circular reference errors
- ✅ No more unhashable type errors
- ✅ No more empty responses
- ✅ Better error messages in logs
- ✅ Graceful degradation when components fail
## Next Steps
The application should now:
1. Handle requests without crashing
2. Generate responses even when some agents fail
3. Log detailed error information for debugging
4. Persist context without circular references
## Additional Improvements
- Added `exc_info=True` to all logger.error() calls for full stack traces
- Improved type handling in safety agent
- Better fallback responses throughout the synthesis chain
- More robust error handling in orchestrator
|